linux-kernel - Re: [PATCH] block/rnbd: Constify struct kobj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22818675-77dd-4a51-93b5-dd9f61265211@nvidia.com>
Date: Tue, 9 Jul 2024 00:54:39 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, "Md. Haris Iqbal"
	<haris.iqbal@...os.com>, Jack Wang <jinpu.wang@...os.com>, Jens Axboe
	<axboe@...nel.dk>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"linux-block@...r.kernel.org" <linux-block@...r.kernel.org>
Subject: Re: [PATCH] block/rnbd: Constify struct kobj_type

On 7/8/2024 11:11 AM, Christophe JAILLET wrote:
> 'struct kobj_type' is not modified in this driver. It is only used with
> kobject_init_and_add() which takes a "const struct kobj_type *" parameter.
> 
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
> 
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
>     text	   data	    bss	    dec	    hex	filename
>     4082	    792	      8	   4882	   1312	drivers/block/rnbd/rnbd-srv-sysfs.o
> 
> After:
> =====
>     text	   data	    bss	    dec	    hex	filename
>     4210	    672	      8	   4890	   131a	drivers/block/rnbd/rnbd-srv-sysfs.o
> 
> Signed-off-by: Christophe JAILLET<christophe.jaillet@...adoo.fr>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck