linux-kernel - Re: [PATCH v2 1/5] arm64: dts: ti: k3-j721s2*: Add bootph-* properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240709084857.nf7c57mi6miajeau@uda0497581>
Date: Tue, 9 Jul 2024 14:18:57 +0530
From: Manorit Chawdhry <m-chawdhry@...com>
To: Vignesh Raghavendra <vigneshr@...com>
CC: Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>,
        Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Neha Malcom
 Francis <n-francis@...com>,
        Aniket Limaye <a-limaye@...com>, Udit Kumar
	<u-kumar1@...com>,
        Beleswar Padhi <b-padhi@...com>
Subject: Re: [PATCH v2 1/5] arm64: dts: ti: k3-j721s2*: Add bootph-*
 properties

Hi Vignesh,

On 13:02-20240709, Vignesh Raghavendra wrote:
> 
> 
> On 05/07/24 11:56, Manorit Chawdhry wrote:
> > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> > index 8feb42c89e47..497e0dfa8011 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> > @@ -17,20 +17,24 @@ sms: system-controller@...83000 {
> >  
> >  		reg-names = "debug_messages";
> >  		reg = <0x00 0x44083000 0x00 0x1000>;
> > +		bootph-all;
> 
> Since [0] in U-Boot, bootph-* is automatically propagated to supernodes.
> Please fix throughout the series

In v1, Aniket posted a review comment and that corresponded to all the
devices hence added that [0]. As you mentioned offline, this node might
be getting called in U-boot proper prior to re-location and somehow the
property is not getting passed on at that stage. Might need some furthur
debugging as to why it's failing. Will see what can be done about it.
Thanks.

[0]: https://lore.kernel.org/all/3e478ecc-33b8-4aa6-b984-67877864e900@ti.com/

Regards,
Manorit

> 
> >  
> >  		k3_pds: power-controller {
> >  			compatible = "ti,sci-pm-domain";
> >  			#power-domain-cells = <2>;
> > +			bootph-all;
> >  		};
> >  
> >  		k3_clks: clock-controller {
> >  			compatible = "ti,k2g-sci-clk";
> >  			#clock-cells = <2>;
> > +			bootph-all;
> >  		};
> >  
> >  		k3_reset: reset-controller {
> >  			compatible = "ti,sci-reset";
> >  			#reset-cells = <2>;
> > +			bootph-all;
> >  		};
> >  	};
> 
> 
> [0]
> 
> -- 
> Regards
> Vignesh