linux-kernel - Re: [PATCH] xfs: convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zo0KYMJkWYirUx1R@dread.disaster.area>
Date: Tue, 9 Jul 2024 20:01:04 +1000
From: Dave Chinner <david@...morbit.com>
To: Chen Ni <nichen@...as.ac.cn>
Cc: chandan.babu@...cle.com, djwong@...nel.org, linux-xfs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: convert comma to semicolon

On Tue, Jul 09, 2024 at 03:36:32PM +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.

Fixes: 8f4b980ee67f ("xfs: pass the attr value to put_listent when possible")

> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  fs/xfs/xfs_attr_list.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
> index 5c947e5ce8b8..7db386304875 100644
> --- a/fs/xfs/xfs_attr_list.c
> +++ b/fs/xfs/xfs_attr_list.c
> @@ -139,7 +139,7 @@ xfs_attr_shortform_list(
>  		sbp->name = sfe->nameval;
>  		sbp->namelen = sfe->namelen;
>  		/* These are bytes, and both on-disk, don't endian-flip */
> -		sbp->value = &sfe->nameval[sfe->namelen],
> +		sbp->value = &sfe->nameval[sfe->namelen];
>  		sbp->valuelen = sfe->valuelen;
>  		sbp->flags = sfe->flags;
>  		sbp->hash = xfs_attr_hashval(dp->i_mount, sfe->flags,

Looks good,

Reviewed-by: Dave Chinner <dchinner@...hat.com>

-- 
Dave Chinner
david@...morbit.com