[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <73a245d2-2e12-476a-b22a-cc11bdcecef0@linux.intel.com>
Date: Tue, 9 Jul 2024 12:10:02 +0200
From: Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>
To: "Alexander F. Lent" <lx@...derlent.com>,
Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>,
Oded Gabbay <ogabbay@...nel.org>, Jeffrey Hugo <quic_jhugo@...cinc.com>,
Daniel Vetter <daniel.vetter@...ll.ch>,
Andrzej Kacprowski <andrzej.kacprowski@...ux.intel.com>,
Krystian Pradzynski <krystian.pradzynski@...ux.intel.com>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] accel/ivpu: Add missing MODULE_FIRMWARE metadata
Hi,
Just two more comments and we are good to go.
On 09.07.2024 02:25, Alexander F. Lent wrote:
> +/* Add module metadata for the production firmware paths.
> + * This needs to be kept in sync with fw_names above.
> + */
I would prefer:
/* Production fw_names from the table above */
> +MODULE_FIRMWARE("intel/vpu/vpu_37xx_v0.0.bin");
> +MODULE_FIRMWARE("intel/vpu/vpu_37xx_v0.0.bin");
You probably meant *40xx*.
Regards,
Jacek
Powered by blists - more mailing lists