linux-kernel - Re: [PATCH v2 3/7] mm: move vma_shrink(), vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c163cdb3-a950-4a61-b125-2f9086ca95ec@suse.cz>
Date: Tue, 9 Jul 2024 12:49:49 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, "Liam R . Howlett" <Liam.Howlett@...cle.com>,
 Matthew Wilcox <willy@...radead.org>,
 Alexander Viro <viro@...iv.linux.org.uk>,
 Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
 Eric Biederman <ebiederm@...ssion.com>, Kees Cook <kees@...nel.org>,
 Suren Baghdasaryan <surenb@...gle.com>, SeongJae Park <sj@...nel.org>,
 Shuah Khan <shuah@...nel.org>, Brendan Higgins <brendanhiggins@...gle.com>,
 David Gow <davidgow@...gle.com>, Rae Moar <rmoar@...gle.com>
Subject: Re: [PATCH v2 3/7] mm: move vma_shrink(), vma_expand() to internal
 header

On 7/4/24 9:27 PM, Lorenzo Stoakes wrote:
> The vma_shrink() and vma_expand() functions are internal VMA manipulation
> functions which we ought to abstract for use outside of memory management
> code.
> 
> To achieve this, we replace shift_arg_pages() in fs/exec.c with an
> invocation of a new relocate_vma_down() function implemented in mm/mmap.c,
> which enables us to also move move_page_tables() and vma_iter_prev_range()
> to internal.h.
> 
> The purpose of doing this is to isolate key VMA manipulation functions in
> order that we can both abstract them and later render them easily testable.
> 
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>

Reviewed-by: Vlastimil Babka <vbabka@...e.cz>

Same nits about some "extern"s that could be removed in the process.