linux-kernel - Re: [PATCH v17] arm64: dts: qcom: sa8295p-adp: Enable the four USB Type-A ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a1a7b1e-1088-483d-894c-19ab4dbb9ce1@linaro.org>
Date: Tue, 9 Jul 2024 13:36:54 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Krishna Kurapati <quic_kriskura@...cinc.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 Bjorn Andersson <andersson@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Johan Hovold <johan@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, quic_ppratap@...cinc.com, quic_jackp@...cinc.com
Subject: Re: [PATCH v17] arm64: dts: qcom: sa8295p-adp: Enable the four USB
 Type-A ports

On 7.07.2024 10:56 AM, Krishna Kurapati wrote:
> The multiport USB controller in the SA8295P ADP is connected to four USB
> Type-A ports. VBUS for each of these ports are provided by a
> TPS2559QWDRCTQ1 regulator, controlled from PMIC GPIOs.
> 
> Add the necessary regulators and GPIO configuration to power these.
> 
> It seems reasonable that these regulators should be referenced as vbus
> supply of usb-a-connector nodes and controlled by e.g. dwc3, but as this
> is not supported in Linux today the regulators are left always-on for
> now.
> 
> Signed-off-by: Krishna Kurapati <quic_kriskura@...cinc.com>
> ---

Looks reasonable, thanks for taking this all the way through the review
process!


Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad