linux-kernel - Re: [PATCH v6] mm: shrink skip folio mapped by an exiting process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zo0ju0NAg2cAikU6@casper.infradead.org>
Date: Tue, 9 Jul 2024 12:49:15 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Zhiguo Jiang <justinjiang@...o.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Barry Song <baohua@...nel.org>,
	David Hildenbrand <david@...hat.com>, opensource.kernel@...o.com
Subject: Re: [PATCH v6] mm: shrink skip folio mapped by an exiting process

On Tue, Jul 09, 2024 at 12:10:50PM +0800, Zhiguo Jiang wrote:
> +		if ((!atomic_read(&vma->vm_mm->mm_users) ||
> +			check_stable_address_space(vma->vm_mm)) &&
> +			folio_test_swapbacked(folio) &&
> +			!folio_likely_mapped_shared(folio)) {
> +			pra->referenced = -1;
> +			page_vma_mapped_walk_done(&pvmw);
> +			return false;
> +		}

You told me you'd fix the indentation.  You cannot indent both the
continuation lines of the condition and the body of the if by one tab
each!