linux-kernel - Re: [PATCH v2 4/4] drm/panic: Add a qr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48cb6b5e-3685-4661-9183-080e25348892@redhat.com>
Date: Tue, 9 Jul 2024 14:02:39 +0200
From: Jocelyn Falempe <jfalempe@...hat.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Wedson Almeida Filho <wedsonaf@...il.com>, Boqun Feng
 <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Bjorn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <benno.lossin@...ton.me>,
 Andreas Hindborg <a.hindborg@...sung.com>, Alice Ryhl
 <aliceryhl@...gle.com>, linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, rust-for-linux@...r.kernel.org,
 Danilo Krummrich <dakr@...hat.com>
Subject: Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen



On 09/07/2024 12:12, Greg KH wrote:
> On Tue, Jul 09, 2024 at 12:04:02PM +0200, Jocelyn Falempe wrote:
>>
>>
>> On 09/07/2024 11:12, Greg KH wrote:
>>> On Tue, Jul 09, 2024 at 11:11:35AM +0200, Greg KH wrote:
>>>> On Tue, Jul 09, 2024 at 10:40:10AM +0200, Jocelyn Falempe wrote:
>>>>> +config DRM_PANIC_SCREEN_QR_CODE_URL
>>>>> +	string "Base url of the QR code in the panic screen"
>>>>> +	depends on DRM_PANIC_SCREEN_QR_CODE
>>>>> +	help
>>>>> +	  This option sets the base url to report the kernel panic. If it's set
>>>>> +	  the qr code will contain the url and the kmsg compressed with zlib as
>>>>> +	  url parameter. If it's empty, the qr code will contain the kmsg as
>>>>> +	  uncompressed text only.
>>>>
>>>> meta-comment, should we by default do this on a kernel.org domain so
>>>> that no specific distro has to worry about hosing this type of web
>>>> service?
>>>
>>> Also, do you have the backend source for this to show how anyone can
>>> host it themselves as well?  We can't add features to the kernel that no
>>> one but closed-source implementations will use for obvious reasons.
>>
>> I've made a proof of concept backend here:
>> https://github.com/kdj0c/panic_report/
>>
>> And the javascript to decode the kmsg trace is here (under MIT licence):
>> https://github.com/kdj0c/panic_report/blob/main/docs/panic_report.js
> 
> SPDX lines are your friend, you might want to look into that for this
> stuff :)

Sure, I've added the SPDX header for this file.
> 
>> It uses the pako js library to uncompress the zlib data, which is also under
>> MIT/Zlib licence https://github.com/nodeca/pako/
> 
> Great, can you put that in the Kconfig help area for this option in your
> next version?

Yes, I will add a link to the panic_report github project.
> 
>> If kernel.org want to host a default service for that, that would be great.
>> It can be linked with https://bugzilla.kernel.org to easily create a bug, or
>> look for similar bugs.
> 
> Someone should at least propose it if this is going to be an option that
> the kernel supports.

I hope someone will volunteer to do that, as I'm not really into web 
development. Also it's a bit early, drm panic is quite new, and needs 
more driver support to be really useful.
> thanks,
> 
> greg k-h
> 


-- 

Jocelyn