[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6af7308b-ab84-4173-968f-c67fc1aef04b@linaro.org>
Date: Tue, 9 Jul 2024 14:19:33 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Sagar Cheluvegowda <quic_scheluve@...cinc.com>,
Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
Andrew Halaney <ahalaney@...hat.com>, kernel@...cinc.com
Subject: Re: [PATCH] arm64: dts: qcom: sa8775p: Add interconnects for ethernet
On 8.07.2024 11:14 PM, Sagar Cheluvegowda wrote:
> Define interconnect properties for ethernet hardware.
>
> Suggested-by: Andrew Halaney <ahalaney@...hat.com>
> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@...cinc.com>
> ---
> Adding interconnect dtsi properties within ethernet node of SA8775P,
> this patch is adding support for the interconnect properties defined
> in the series ->
> https://lore.kernel.org/all/20240703-icc_bw_voting_from_ethqos-v3-0-8f9148ac60a3@quicinc.com/
> ---
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 23f1b2e5e624..7ebf03953b7b 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -3464,6 +3464,12 @@ ethernet1: ethernet@...00000 {
> "ptp_ref",
> "phyaux";
>
> + interconnect-names = "mac-mem", "cpu-mac";
> + interconnects = <&aggre1_noc MASTER_EMAC_1 QCOM_ICC_TAG_ALWAYS
> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
> + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
> + &config_noc SLAVE_EMAC1_CFG QCOM_ICC_TAG_ALWAYS>;
property
property-names
please
otherwise lgtm
Konrad
Powered by blists - more mailing lists