linux-kernel - Re: [PATCH 1/3] sched_ext: Take out ->priq and ->flags from scx_dsq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240709122454.GA16568@maniforge>
Date: Tue, 9 Jul 2024 07:24:54 -0500
From: David Vernet <void@...ifault.com>
To: Tejun Heo <tj@...nel.org>
Cc: ast@...nel.org, andrii@...nel.org, linux-kernel@...r.kernel.org,
	bpf@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH 1/3] sched_ext: Take out ->priq and ->flags from
 scx_dsq_node

On Mon, Jul 08, 2024 at 02:40:22PM -1000, Tejun Heo wrote:
> struct scx_dsq_node contains two data structure nodes to link the containing
> task to a DSQ and a flags field that is protected by the lock of the
> associated DSQ. One reason why they are grouped into a struct is to use the
> type independently as a cursor node when iterating tasks on a DSQ. However,
> when iterating, the cursor only needs to be linked on the FIFO list and the
> rb_node part ends up inflating the size of the iterator data structure
> unnecessarily making it potentially too expensive to place it on stack.
> 
> Take ->priq and ->flags out of scx_dsq_node and put them in sched_ext_entity
> as ->dsq_priq and ->dsq_flags, respectively. scx_dsq_node is renamed to
> scx_dsq_list_node and the field names are renamed accordingly. This will
> help implementing DSQ task iterator that can be allocated on stack.
> 
> No functional change intended.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Suggested-by: Alexei Starovoitov <ast@...nel.org>
> Acked-by: Alexei Starovoitov <ast@...nel.org>
> Cc: David Vernet <void@...ifault.com>

Reviewed-by: David Vernet <void@...ifault.com>

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)