linux-kernel - Re: [PATCH v4 1/2] dt-bindings: mmc: nuvoton,ma35d1-sdhci: Document MA35D1 SDHCI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f1053686-1eaf-4a84-af57-4d25dc5896f2@gmail.com>
Date: Tue, 9 Jul 2024 10:10:36 +0800
From: Shan-Chun Hung <shanchun1218@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, ulf.hansson@...aro.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 adrian.hunter@...el.com, p.zabel@...gutronix.de, pbrobinson@...il.com,
 serghox@...il.com, mcgrof@...nel.org,
 prabhakar.mahadev-lad.rj@...renesas.com, forbidden405@...look.com,
 tmaimon77@...il.com, andy.shevchenko@...il.com,
 linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: ychuang3@...oton.com, schung@...oton.com
Subject: Re: [PATCH v4 1/2] dt-bindings: mmc: nuvoton,ma35d1-sdhci: Document
 MA35D1 SDHCI controller

Dear Krzysztof,

Thank you for your review.

I will make sure to keep the same order as in the list of properties.

I'm sorry if I missed your comments before.

I will do my best to address them in the future.

Thanks for your understanding.


Best Regards

Shan-Chun


On 2024/7/8 下午 10:19, Krzysztof Kozlowski wrote:
> On 04/07/2024 08:26, Shan-Chun Hung wrote:
>> Add binding for Nuvoton MA35D1 SDHCI controller.
>>
>> Signed-off-by: Shan-Chun Hung <shanchun1218@...il.com>
>> ---
>
>> +
>> +  nuvoton,sys:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description: phandle to access GCR (Global Control Register) registers.
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - clocks
>> +  - pinctrl-names
>> +  - pinctrl-0
>> +  - resets
>> +  - nuvoton,sys
> Keep the same order as in list of properties.
>
> Normally I would give conditional review tag, but not that case because
> in the past you kept ignoring review comments.
>
> Best regards,
> Krzysztof
>