linux-kernel - Re: [PATCH] sched/fair: Remove stale buddies comment for last and skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKfTPtB=5Se427by2ntnkW4gD8p6xL39mipVvcRFdH4fLOPjKQ@mail.gmail.com>
Date: Tue, 9 Jul 2024 15:54:01 +0200
From: Vincent Guittot <vincent.guittot@...aro.org>
To: Bing Huang <huangbing775@....com>
Cc: dietmar.eggemann@....com, rostedt@...dmis.org, brauner@...nel.org, 
	bsegall@...gle.com, juri.lelli@...hat.com, linux-kernel@...r.kernel.org, 
	mgorman@...e.de, mingo@...hat.com, peterz@...radead.org
Subject: Re: [PATCH] sched/fair: Remove stale buddies comment for last and skip

On Sat, 6 Jul 2024 at 11:10, Bing Huang <huangbing775@....com> wrote:
>
> From: Bing Huang <huangbing@...inos.cn>
>
> commit 5e963f2bd465 ("sched/fair: Commit to EEVDF") has removed last and
> skip. Modify the comment accordingly.
>
> Signed-off-by: Bing Huang <huangbing@...inos.cn>

Acked-by: Vincent Guittot <vincent.guittot@...aro.org>

> ---
>  kernel/sched/fair.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 41b58387023d..383582f87def 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5466,8 +5466,6 @@ set_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
>   * Pick the next process, keeping these things in mind, in this order:
>   * 1) keep things fair between processes/task groups
>   * 2) pick the "next" process, since someone really wants that to run
> - * 3) pick the "last" process, for cache locality
> - * 4) do not run the "skip" process, if something else is available
>   */
>  static struct sched_entity *
>  pick_next_entity(struct cfs_rq *cfs_rq)
> --
> 2.25.1
>