linux-kernel - Re: [PATCH 0/2] virtio-fs: Add 'file' mount option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240710172828.GB542210@dynamic-pd01.res.v6.highway.a1.net>
Date: Wed, 10 Jul 2024 19:28:28 +0200
From: Stefan Hajnoczi <stefanha@...hat.com>
To: Hanna Czenczek <hreitz@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-doc@...r.kernel.org, virtualization@...ts.linux.dev,
	Miklos Szeredi <mszeredi@...hat.com>,
	German Maglione <gmaglione@...hat.com>,
	Eugenio Pérez <eperezma@...hat.com>,
	Jonathan Corbet <corbet@....net>, Vivek Goyal <vgoyal@...hat.com>
Subject: Re: [PATCH 0/2] virtio-fs: Add 'file' mount option

On Tue, Jul 09, 2024 at 01:19:16PM +0200, Hanna Czenczek wrote:
> Hi,
> 
> We want to be able to mount filesystems that just consist of one regular
> file via virtio-fs, i.e. no root directory, just a file as the root
> node.
> 
> While that is possible via FUSE itself (through the 'rootmode' mount
> option, which is automatically set by the fusermount help program to
> match the mount point's inode mode), there is no virtio-fs option yet
> that would allow changing the rootmode from S_IFDIR to S_IFREG.
> 
> To do that, this series introduces a new 'file' mount option that does
> precisely that.  Alternatively, we could provide the same 'rootmode'
> option that FUSE has, but as laid out in patch 1's commit description,
> that option is a bit cumbersome for virtio-fs (in a way that it is not
> for FUSE), and its usefulness as a more general option is limited.
> 
> 
> Hanna Czenczek (2):
>   virtio-fs: Add 'file' mount option
>   virtio-fs: Document 'file' mount option
> 
>  fs/fuse/virtio_fs.c                    | 9 ++++++++-
>  Documentation/filesystems/virtiofs.rst | 5 ++++-
>  2 files changed, 12 insertions(+), 2 deletions(-)
> 
> -- 
> 2.45.1
> 

Looks good to me. Maybe add the 'file' option to FUSE as well to keep
them in sync (eventually rootmode could be exposed to virtiofs too, if
necessary)?

Reviewed-by: Stefan Hajnoczi <stefanha@...hat.com>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)