linux-kernel - [PATCH] mm: Give kmap_lock before call flush_tlb_kernel_rang，avoid kmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1720580871-27946-1-git-send-email-zhang.chuna@h3c.com>
Date: Wed, 10 Jul 2024 11:07:51 +0800
From: zhangchun <zhang.chuna@....com>
To: <willy@...radead.org>
CC: <akpm@...ux-foundation.org>, <jiaoxupo@....com>,
        <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        <shaohaojize@....com>, <zhang.chuna@....com>,
        <zhang.zhansheng@....com>, <zhang.zhengming@....com>
Subject: [PATCH] mm: Give kmap_lock before call flush_tlb_kernel_rang，avoid kmap_high deadlock V2.

>> +++ b/mm/highmem.c
>> @@ -220,8 +220,11 @@ static void flush_all_zero_pkmaps(void)
>>  		set_page_address(page, NULL);
>>  		need_flush = 1;
>>  	}
>> -	if (need_flush)
>> +	if (need_flush) {
>> +		spin_unlock(&kmap_lock);

>should this be a raw spin_unlock(), or should it be unlock_kmap()?
>ie when ARCH_NEEDS_KMAP_HIGH_GET is set, do we also need to re-enable interrupts here?

Thanks! Using lock_map/unlock_kmap is better.
Patch V2 will be sent.
 
1.8.3.1