linux-kernel - Re: [PATCH 1/2] selftests/thermel/intel: conform the test to TAP output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <415baa3e-1bbe-4da0-8f69-d4e818f45925@linuxfoundation.org>
Date: Wed, 10 Jul 2024 12:15:12 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>,
 Muhammad Usama Anjum <usama.anjum@...labora.com>,
 Shuah Khan <shuah@...nel.org>, "Rafael J. Wysocki"
 <rafael.j.wysocki@...el.com>
Cc: kernel@...labora.com, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 1/2] selftests/thermel/intel: conform the test to TAP
 output

On 7/1/24 03:38, srinivas pandruvada wrote:
> On Mon, 2024-07-01 at 13:36 +0500, Muhammad Usama Anjum wrote:
>> Soft reminder
>>
>> On 5/22/24 10:06 PM, Muhammad Usama Anjum wrote:
>>> Conform the layout, informational and status messages to TAP. No
>>> functional change is intended other than the layout of output
>>> messages.
>>>
>>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
>>> ---

Okay. I think I responded to your other patches that are adding TAP
to individual tests when kselftest wrapped does it for you based on
return values.

The reason I don't want to take this patch is if you run the test
using the recommended method:

make -C tools/testing/selftests/vDSO/ run_tests you will get the
TAP output because lib.mk runtests framework takes care of this.

or

make kselftest TARGETS=vDSO will do the same.

Please don't send TAP conversions for individual runs. You will
start seeing duplicate TAP output which will make it unreadable.

Run the test using make -C or make kselftest TARGETS before
investing time to concert to TAP. I am not going to take TAP
conversions patches if make -C or make kselftest TARGETS
shows TAP.

thanks,
-- Shuah