linux-kernel - Re: [PATCH v2 0/2] virtio-balloon: make it spec compliant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9405f5d-2b43-40bf-b496-9eaae7c873c5@redhat.com>
Date: Wed, 10 Jul 2024 20:25:56 +0200
From: David Hildenbrand <david@...hat.com>
To: "Michael S. Tsirkin" <mst@...hat.com>, linux-kernel@...r.kernel.org
Cc: Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
 Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
 Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2 0/2] virtio-balloon: make it spec compliant

On 10.07.24 13:42, Michael S. Tsirkin wrote:
> Currently, if VIRTIO_BALLOON_F_FREE_PAGE_HINT is off but
> VIRTIO_BALLOON_F_REPORTING is on, then the reporting vq
> gets number 3 while spec says it's number 4.
> It happens to work because the qemu virtio pci driver
> is *also* out of spec.
> 
> To fix:
> 1. add vq4 as per spec
> 2. to help out the buggy qemu driver, if finding vqs fail,
> try with vq3 as reporting.
> 
> Fixes: b0c504f15471 ("virtio-balloon: add support for providing free page reports to host")
> Cc: "Alexander Duyck" <alexander.h.duyck@...ux.intel.com>
> Reported-by: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> 
> Changes from v1:
> 	rebased on vhost tip
> 

Looks like you missed to include acks from me and Jason.

-- 
Cheers,

David / dhildenb