linux-kernel - Re: [PATCH v2 0/2] virtio-balloon: make it spec compliant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240710144053-mutt-send-email-mst@kernel.org>
Date: Wed, 10 Jul 2024 14:41:34 -0400
From: "Michael S. Tsirkin" <mst@...hat.com>
To: David Hildenbrand <david@...hat.com>
Cc: linux-kernel@...r.kernel.org,
	Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2 0/2] virtio-balloon: make it spec compliant

On Wed, Jul 10, 2024 at 08:25:56PM +0200, David Hildenbrand wrote:
> On 10.07.24 13:42, Michael S. Tsirkin wrote:
> > Currently, if VIRTIO_BALLOON_F_FREE_PAGE_HINT is off but
> > VIRTIO_BALLOON_F_REPORTING is on, then the reporting vq
> > gets number 3 while spec says it's number 4.
> > It happens to work because the qemu virtio pci driver
> > is *also* out of spec.
> > 
> > To fix:
> > 1. add vq4 as per spec
> > 2. to help out the buggy qemu driver, if finding vqs fail,
> > try with vq3 as reporting.
> > 
> > Fixes: b0c504f15471 ("virtio-balloon: add support for providing free page reports to host")
> > Cc: "Alexander Duyck" <alexander.h.duyck@...ux.intel.com>
> > Reported-by: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
> > Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> > 
> > Changes from v1:
> > 	rebased on vhost tip
> > 
> 
> Looks like you missed to include acks from me and Jason.
> 
> -- 
> Cheers,
> 
> David / dhildenb


indeed they are on lore but not in the mbox, weird. fixed - thanks
for pointing this out.