linux-kernel - Re: [PATCH v4 17/21] mm/mmap: Drop arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9e94bb8-e45d-4fb7-9811-b6c7e78c537f@intel.com>
Date: Wed, 10 Jul 2024 12:27:21 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: "Liam R. Howlett" <Liam.Howlett@...cle.com>, linux-mm@...ck.org,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: Suren Baghdasaryan <surenb@...gle.com>, Vlastimil Babka <vbabka@...e.cz>,
 Lorenzo Stoakes <lstoakes@...il.com>, Matthew Wilcox <willy@...radead.org>,
 sidhartha.kumar@...cle.com, "Paul E . McKenney" <paulmck@...nel.org>,
 Bert Karwatzki <spasswolf@....de>, Jiri Olsa <olsajiri@...il.com>,
 linux-kernel@...r.kernel.org, Kees Cook <kees@...nel.org>,
 LEROY Christophe <christophe.leroy2@...soprasteria.com>,
 linuxppc-dev@...ts.ozlabs.org, Dmitry Safonov <dima@...sta.com>,
 Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH v4 17/21] mm/mmap: Drop arch_unmap() call from all archs

On 7/10/24 12:22, Liam R. Howlett wrote:
> The arch_unmap call was previously moved above the rbtree modifications
> in commit 5a28fc94c914 ("x86/mpx, mm/core: Fix recursive munmap()
> corruption").  The move was motivated by an issue with calling
> arch_unmap() after the rbtree was modified.
> 
> Since the above commit, mpx was dropped from the kernel in 45fc24e89b7c
> ("x86/mpx: remove MPX from arch/x86"), so the motivation for calling
> arch_unmap() prior to modifying the vma tree no longer exists
> (regardless of rbtree or maple tree implementations).
> 
> Furthermore, the powerpc implementation is also no longer needed as per
> [1] and [2].  So the arch_unmap() function can be completely removed.

Thanks for doing this cleanup, Liam!

Acked-by: Dave Hansen <dave.hansen@...el.com>