linux-kernel - Re: [PATCH v5 2/7] KVM: Add KVM_PRE_FAULT_MEMORY vcpu ioctl to pre-populate guest memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF7b7mogOgTs5FZMfuUDms2uHqy3_CNu7p=3TanLzHkem=EMyA@mail.gmail.com>
Date: Wed, 10 Jul 2024 13:46:06 -0700
From: Anish Moorthy <amoorthy@...gle.com>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org, 
	isaku.yamahata@...el.com, seanjc@...gle.com, binbin.wu@...ux.intel.com, 
	xiaoyao.li@...el.com, Rick Edgecombe <rick.p.edgecombe@...el.com>
Subject: Re: [PATCH v5 2/7] KVM: Add KVM_PRE_FAULT_MEMORY vcpu ioctl to
 pre-populate guest memory

On Wed, Jul 10, 2024 at 10:41 AM Paolo Bonzini <pbonzini@...hat.com> wrote:
>
> +       if (!PAGE_ALIGNED(range->gpa) ||
> +           !PAGE_ALIGNED(range->size) ||
> ...
> +               return -EINVAL;

If 'gpa' and 'size' must be page-aligned anyways, doesn't it make
sense to just take a 'gfn' and 'num_pages'  and eliminate this error
condition?