linux-kernel - Re: [PATCH v2 28/60] i2c: ls2x: reword according to newest specification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fvj3rmm2zrtpdn73auqkecltr5f4tq7j6be2exd65hjbvdarke@yjlovdeprmiz>
Date: Wed, 10 Jul 2024 23:56:24 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: linux-i2c@...r.kernel.org, Binbin Zhou <zhoubinbin@...ngson.cn>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 28/60] i2c: ls2x: reword according to newest
 specification

Hi Wolfram,

On Sat, Jul 06, 2024 at 01:20:28PM GMT, Wolfram Sang wrote:
> Change the wording of this driver wrt. the newest I2C v7 and SMBus 3.2
> specifications and replace "master/slave" with more appropriate terms.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

...

> -#define LS2X_CTR_MST		BIT(5) /* 0: Slave mode 1: Master mode */
> +#define LS2X_CTR_MST		BIT(5) /* 0: Target mode 1: Controller mode */

heh! I believe MST stands for master, but this is one of those
cases where it doesn't make sense to change as the naming it's
imposed by the hardware specs.

Reviewed-by: Andi Shyti <andi.shyti@...nel.org>

Thanks,
Andi