linux-kernel - Re: [PATCH] dmaengine: idxd: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <24079077-ada9-0150-e542-0002ae3e9b61@intel.com>
Date: Wed, 10 Jul 2024 16:39:12 -0700
From: Fenghua Yu <fenghua.yu@...el.com>
To: Chen Ni <nichen@...as.ac.cn>, <dave.jiang@...el.com>, <vkoul@...nel.org>
CC: <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: idxd: Convert comma to semicolon



On 7/9/24 20:07, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.

better to add "for more readability."

Otherwise, there is no issue with the commas.

> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>

Reviewed-by: Fenghua Yu <fenghua.yu@...el.com>

> ---
>   drivers/dma/idxd/perfmon.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/idxd/perfmon.c b/drivers/dma/idxd/perfmon.c
> index 5e94247e1ea7..e596ea60ed3c 100644
> --- a/drivers/dma/idxd/perfmon.c
> +++ b/drivers/dma/idxd/perfmon.c
> @@ -480,8 +480,8 @@ static void idxd_pmu_init(struct idxd_pmu *idxd_pmu)
>   	idxd_pmu->pmu.attr_groups	= perfmon_attr_groups;
>   	idxd_pmu->pmu.task_ctx_nr	= perf_invalid_context;
>   	idxd_pmu->pmu.event_init	= perfmon_pmu_event_init;
> -	idxd_pmu->pmu.pmu_enable	= perfmon_pmu_enable,
> -	idxd_pmu->pmu.pmu_disable	= perfmon_pmu_disable,
> +	idxd_pmu->pmu.pmu_enable	= perfmon_pmu_enable;
> +	idxd_pmu->pmu.pmu_disable	= perfmon_pmu_disable;
>   	idxd_pmu->pmu.add		= perfmon_pmu_event_add;
>   	idxd_pmu->pmu.del		= perfmon_pmu_event_del;
>   	idxd_pmu->pmu.start		= perfmon_pmu_event_start;

Thanks.

-Fenghua