linux-kernel - Re: [PATCH v9 10/13] PCI: Give pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240710044308.GA3755660@rocinante>
Date: Wed, 10 Jul 2024 13:43:08 +0900
From: Krzysztof Wilczyński <kw@...ux.com>
To: Philipp Stanner <pstanner@...hat.com>
Cc: Ashish Kalra <Ashish.Kalra@....com>, airlied@...il.com,
	bhelgaas@...gle.com, dakr@...hat.com, daniel@...ll.ch,
	dri-devel@...ts.freedesktop.org, hdegoede@...hat.com,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
	sam@...nborg.org, tzimmermann@...e.de, thomas.lendacky@....com,
	mario.limonciello@....com
Subject: Re: [PATCH v9 10/13] PCI: Give pci_intx() its own devres callback

[...]
> pci_intx() calls into pcim_intx() in managed mode, i.e., when
> pcim_enable_device() had been called. This recursive call causes a bug
> by re-registering the device resource in the release callback.
> 
> This is the same phenomenon that made it necessary to implement some
> functionality a second time, see __pcim_request_region().
> 
> Implement __pcim_intx() to bypass the hybrid nature of pci_intx() on
> driver detach.

Squashed against devres branch, thank you!  See:

  https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=devres&id=37c9f6c55cfd63a9e38a98b5aa1d7da75845c2b2

To credit Ashish, I kept the Fixes: and Tested-by: tags.

	Krzysztof