linux-kernel - Re: [PATCH 2/3] PCI: qcom: Prevent potential error pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240710054322.GA3763187@rocinante>
Date: Wed, 10 Jul 2024 14:43:22 +0900
From: Krzysztof Wilczyński <kw@...ux.com>
To: Anders Roxell <anders.roxell@...aro.org>
Cc: dan.carpenter@...aro.org,
	Krishna chaitanya chundru <quic_krichai@...cinc.com>,
	bhelgaas@...gle.com, linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	lpieralisi@...nel.org, manivannan.sadhasivam@...aro.org,
	robh@...nel.org
Subject: Re: [PATCH 2/3] PCI: qcom: Prevent potential error pointer
 dereference

Hello,

[...]
> > Only call dev_pm_opp_put() if dev_pm_opp_find_freq_exact() succeeds.
> > Otherwise it leads to an error pointer dereference.
> > 
> > Fixes: 78b5f6f8855e ("PCI: qcom: Add OPP support to scale performance")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> 
> Tested-by: Anders Roxell <anders.roxell@...aro.org>
> 
> Applied this patch ontop of linux-next tag, next-20240709.
> 
> Booted fine on dragonboard-845c HW.

Thank you for testing!

I took the liberty and added your Tested-by: tag to the relevant commits
on our controller/qcom branch.

	Krzysztof