linux-kernel - RE: [PATCH] iommu/vt-d: Fix identity map bounds in si_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5276C05D3B3B8821420BBD6E8CA42@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Wed, 10 Jul 2024 00:49:05 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Jon Pan-Doh <pandoh@...gle.com>, David Woodhouse <dwmw2@...radead.org>, Lu
 Baolu <baolu.lu@...ux.intel.com>
CC: Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>, "Robin
 Murphy" <robin.murphy@....com>, "H. Peter Anvin" <hpa@...ux.intel.com>, Tejun
 Heo <tj@...nel.org>, "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Sudheer
 Dantuluri" <dantuluris@...gle.com>, Gary Zibrat <gzibrat@...gle.com>
Subject: RE: [PATCH] iommu/vt-d: Fix identity map bounds in si_domain_init()

> From: Jon Pan-Doh <pandoh@...gle.com>
> Sent: Wednesday, July 10, 2024 7:49 AM
> 
> Intel IOMMU operates on inclusive bounds (both generally aas well as

s/aas/as/

> iommu_domain_identity_map()). Meanwhile, for_each_mem_pfn_range()
> uses
> exclusive bounds for end_pfn. This creates an off-by-one error when
> switching between the two.
> 
> Fixes: 5dfe8660a3d7 ("bootmem: Replace work_with_active_regions() with
> for_each_mem_pfn_range()")

this doesn't appear to be the original commit introducing this bug.

Even the old work_with_active_regions() way used exclusive end_pfn
while it's not adjusted when calling iommu_domain_identity_map().

> Signed-off-by: Jon Pan-Doh <pandoh@...gle.com>
> Tested-by: Sudheer Dantuluri <dantuluris@...gle.com>
> Suggested-by: Gary Zibrat <gzibrat@...gle.com>

otherwise,

Reviewed-by: Kevin Tian <kevin.tian@...el.com>