linux-kernel - Re: [PATCH 1/2] ASoC: dt-bindings: qcom,msm8916-wcd-digital-codec: convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f1d3c63-8b1c-43a8-b002-5399a81e704d@kernel.org>
Date: Wed, 10 Jul 2024 10:25:53 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rayyan Ansari <rayyan.ansari@...aro.org>, devicetree@...r.kernel.org
Cc: alsa-devel@...a-project.org, Banajit Goswami <bgoswami@...cinc.com>,
 Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-sound@...r.kernel.org, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: qcom,msm8916-wcd-digital-codec:
 convert to dtschema

On 09/07/2024 17:24, Rayyan Ansari wrote:
> Convert the Qualcomm MSM8916 WCD Digital Audio Codec bindings from text
> to yaml dt schema format.
> Make bindings complete by adding #sound-dai-cells.


> +
> +properties:
> +  compatible:
> +    const: qcom,msm8916-wcd-digital-codec
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    minItems: 2

You can drop minItems if they equal max.

> +    maxItems: 2
> +
> +  clock-names:
> +    items:
> +      - const: ahbix-clk
> +      - const: mclk
> +
> +  '#sound-dai-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - '#sound-dai-cells'
> +

You need here allOf: with $ref to dai-common.yaml.

> +additionalProperties: false

... and this then becomes:
unevaluatedProperties: false


Best regards,
Krzysztof