linux-kernel - Re: [PATCH 0/4] selftest: x86: conform tests to TAP format output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7eb356d-6fe7-4e36-9fd2-1518addc7bdb@collabora.com>
Date: Wed, 10 Jul 2024 13:58:13 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Shuah Khan <skhan@...uxfoundation.org>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org
Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>, kernel@...labora.com,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH 0/4] selftest: x86: conform tests to TAP format output

Hi Shuah,

Thank you for replying.

On 7/10/24 4:39 AM, Shuah Khan wrote:
> On 7/2/24 04:17, Muhammad Usama Anjum wrote:
>> On 6/10/24 10:19 AM, Muhammad Usama Anjum wrote:
>>> Adding Borislav, Dave and x86 mailing list:
>>>     Please review the series.
>> Kind reminder
>>
> 
> Usama,
> 
> As I mentioned another TAP conversion patch from you  patch if the
> following command gives you TAP, there is  no need to convert.
> 
> make -C tools/testing/tmp2 run_tests
> make kselftest TARGETS=tmp2
> 
> kselftest framework lib.mk and runtests wrappers take care for
> TAP. The reason to take care of this at framework level is to
> avoid changes to individual tests. The wrapper keys off of
> KSFT_* codes returned from tests.
> 
> Please don't send TAP conversion patches like this one. The output
> from the commands will have duplicate messages. The reason tests
> return
> 
> make -C tools/testing/tmp2 run_tests
> make kselftest TARGETS=tmp2
The current series have several improvements which are beneficial in
several ways. I think these improvements should be included. While
conforming for TAP following improvements have been made:

*[PATCH 1/4] check_initial_reg_state*
Removes manual counting of pass and fail tests
Increase readability and maintainability of tests
Print logs in standard format (without [RUN], [OK] tags)

*[PATCH 2/4] corrupt_xstate_header*
Correct the skip, pass and fail return codes. Otherwise the test always
return 0
Returns correct number of stats about passed/failed tests
Print logs in standard format

*[PATCH 3/4] fsgsbase_restore*
Add test skip support instead of returning success at skip time for the
kselftest script to understand correct exit status
Print details about errno if error occurs
Increase readability and maintainability
Print logs in standard format

*[PATCH 4/4 entry_from_vm86*
Remove manual pass/fail tests counting
Increase readability
Print details about errno if error occurs
Print logs in standard format


These improvements aren't evident from the description of patches as I
thought converting to TAP achieves all this by default. But I can improve
the patches description and send patch revision. Thoughts?

-- 
BR,
Muhammad Usama Anjum