linux-kernel - Re: [PATCH net-next v2] net: psample: fix flag being set in wrong skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F2D00F9E-8714-4D49-8D74-8310708AA11C@redhat.com>
Date: Wed, 10 Jul 2024 11:17:44 +0200
From: Eelco Chaudron <echaudro@...hat.com>
To: Adrian Moreno <amorenoz@...hat.com>
Cc: netdev@...r.kernel.org, Yotam Gigi <yotam.gi@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Ido Schimmel <idosch@...dia.com>, Aaron Conole <aconole@...hat.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: psample: fix flag being set in wrong skb

On 10 Jul 2024, at 11:07, Adrian Moreno wrote:

> A typo makes PSAMPLE_ATTR_SAMPLE_RATE netlink flag be added to the wrong
> sk_buff.
>
> Fix the error and make the input sk_buff pointer "const" so that it
> doesn't happen again.
>
> Also modify OVS psample test to verify the flag is properly emitted.
>
> Fixes: 7b1b2b60c63f ("net: psample: allow using rate as probability")
> Signed-off-by: Adrian Moreno <amorenoz@...hat.com>

Thank you for fixing this so quickly. The change looks good, and I've verified it with the OVS userspace part.

Acked-by: Eelco Chaudron <echaudro@...hat.com>

Cheers,

Eelco