linux-kernel - Re: [PATCH v2] dt-bindings: crypto: ice: Document QCS9100 inline crypto engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46239515-badb-4ad7-8280-91074eae47bf@kernel.org>
Date: Wed, 10 Jul 2024 12:16:39 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Tengfei Fan <quic_tengfan@...cinc.com>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-crypto@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel@...cinc.com, Maria Yu <quic_aiquny@...cinc.com>
Subject: Re: [PATCH v2] dt-bindings: crypto: ice: Document QCS9100 inline
 crypto engine

On 09/07/2024 15:08, Tengfei Fan wrote:
> Document the compatible used for the inline crypto engine found on
> QCS9100.
> 
> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
> platform use non-SCMI resource. In the future, the SA8775p platform will
> move to use SCMI resources and it will have new sa8775p-related device
> tree. Consequently, introduce "qcom,qcs9100-inline-crypto-engine" to
> describe non-SCMI based crypto engine.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
> ---
> Introduce support for the QCS9100 SoC device tree (DTSI) and the
> QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
> While the QCS9100 platform is still in the early design stage, the
> QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
> mounts the QCS9100 SoC instead of the SA8775p SoC.
> 
> The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
> all the compatible strings will be updated from "SA8775p" to "QCS9100".
> The QCS9100 device tree patches will be pushed after all the device tree
> bindings and device driver patches are reviewed.
> 
> The final dtsi will like:
> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/
>  
> The detailed cover letter reference:
> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
> 
> Co-developed-by: Maria Yu <quic_aiquny@...cinc.com>
> Signed-off-by: Maria Yu <quic_aiquny@...cinc.com>

This looks messy - wrongly placed, not in correct DCO order. Some tools
will just ignore it, some might produce wrong result.

Best regards,
Krzysztof