[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240710103352.1890726-1-make24@iscas.ac.cn>
Date: Wed, 10 Jul 2024 18:33:52 +0800
From: Ma Ke <make24@...as.ac.cn>
To: fbarrat@...ux.ibm.com,
ajd@...ux.ibm.com,
arnd@...db.de,
gregkh@...uxfoundation.org,
clombard@...ux.vnet.ibm.com,
imunsie@....ibm.com,
mpe@...erman.id.au,
manoj@...ux.vnet.ibm.com
Cc: linuxppc-dev@...ts.ozlabs.org,
linux-kernel@...r.kernel.org,
Ma Ke <make24@...as.ac.cn>,
stable@...r.kernel.org
Subject: [PATCH v2] cxl: Fix possible null pointer dereference in read_handle()
In read_handle(), of_get_address() may return NULL which is later
dereferenced. Fix this by adding NULL check.
Cc: stable@...r.kernel.org
Fixes: 14baf4d9c739 ("cxl: Add guest-specific code")
Signed-off-by: Ma Ke <make24@...as.ac.cn>
---
Changes in v2:
- The potential vulnerability was discovered as follows: based on our
customized static analysis tool, extract vulnerability features[1], and
then match similar vulnerability features in this function.
- Reference link:
[1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=2d9adecc88ab678785b581ab021f039372c324cb
---
drivers/misc/cxl/of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cxl/of.c b/drivers/misc/cxl/of.c
index bcc005dff1c0..d8dbb3723951 100644
--- a/drivers/misc/cxl/of.c
+++ b/drivers/misc/cxl/of.c
@@ -58,7 +58,7 @@ static int read_handle(struct device_node *np, u64 *handle)
/* Get address and size of the node */
prop = of_get_address(np, 0, &size, NULL);
- if (size)
+ if (!prop || size)
return -EINVAL;
/* Helper to read a big number; size is in cells (not bytes) */
--
2.25.1
Powered by blists - more mailing lists