linux-kernel - Re: [PATCH v6 8/9] soc: qcom: cpr3: Add IPQ9574 definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c3ada32-1476-4d98-89d7-7b2ffa0f9a65@linaro.org>
Date: Wed, 10 Jul 2024 13:12:19 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, andersson@...nel.org,
 mturquette@...libre.com, sboyd@...nel.org, ilia.lin@...nel.org,
 rafael@...nel.org, viresh.kumar@...aro.org, ulf.hansson@...aro.org,
 quic_sibis@...cinc.com, quic_rjendra@...cinc.com, danila@...xyga.com,
 neil.armstrong@...aro.org, otto.pflueger@...cue.de, abel.vesa@...aro.org,
 luca@...tu.xyz, geert+renesas@...der.be, stephan.gerhold@...nkonzept.com,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-clk@...r.kernel.org
Cc: Praveenkumar I <quic_ipkumar@...cinc.com>
Subject: Re: [PATCH v6 8/9] soc: qcom: cpr3: Add IPQ9574 definitions

On 10.07.2024 8:11 AM, Varadarajan Narayanan wrote:
> From: Praveenkumar I <quic_ipkumar@...cinc.com>
> 
> * Add thread, scaling factor, CPR descriptor defines to enable
>   CPR on IPQ9574.
> 
> * Skip 'acc' usage since IPQ9574 does not have acc
> 
> Signed-off-by: Praveenkumar I <quic_ipkumar@...cinc.com>
> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> ---

[...]

>  
>  	/* CPRh disallows MEM-ACC access from the HLOS */
> -	if (!(data->acc_desc || desc->cpr_type == CTRL_TYPE_CPRH))
> +	if (!(data->acc_desc || desc->cpr_type == CTRL_TYPE_CPRH ||
> +	      of_device_is_compatible(dev->of_node, "qcom,ipq9574-cpr4")))
>  		return dev_err_probe(dev, -EINVAL, "Invalid ACC data\n");

This is something I'd also like to fold into v16.. perhaps 

if (data->acc_desc && desc->cpr_type == CTRL_TYPE_CPRH)

could work instead? this way we trust the programmer that
acc_desc's presence/absence is intentional and only throw and
error if it's present with type == CPRH

Konrad