linux-kernel - RE: [PATCH v3 1/1] swiotlb: Reduce swiotlb pool lookups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SN6PR02MB4157E5175E5EF9DEC6E2C610D4A42@SN6PR02MB4157.namprd02.prod.outlook.com>
Date: Wed, 10 Jul 2024 11:44:32 +0000
From: Michael Kelley <mhklinux@...look.com>
To: Petr Tesařík <petr@...arici.cz>, Christoph Hellwig
	<hch@....de>
CC: "mhkelley58@...il.com" <mhkelley58@...il.com>, "robin.murphy@....com"
	<robin.murphy@....com>, "joro@...tes.org" <joro@...tes.org>,
	"will@...nel.org" <will@...nel.org>, "jgross@...e.com" <jgross@...e.com>,
	"sstabellini@...nel.org" <sstabellini@...nel.org>,
	"oleksandr_tyshchenko@...m.com" <oleksandr_tyshchenko@...m.com>,
	"m.szyprowski@...sung.com" <m.szyprowski@...sung.com>,
	"iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>
Subject: RE: [PATCH v3 1/1] swiotlb: Reduce swiotlb pool lookups

From: Petr Tesařík <petr@...arici.cz> Sent: Wednesday, July 10, 2024 4:32 AM
> 
> On Wed, 10 Jul 2024 07:55:20 +0200
> Christoph Hellwig <hch@....de> wrote:
> 
> > On Tue, Jul 09, 2024 at 09:08:18PM +0200, Petr Tesařík wrote:
> > > I'm confused. If you're not a big fan, why are we effectively adding
> > > them to more places now than before the patch?
> >
> > Because I didn't want to second guess the patch author too much.
> 
> Fair enough. I don't have any relevant test cases either, so when/if
> somebody encounters an issue, let them change it then.
> 

Works for me. FWIW, I don't have a preference either way. I was trying
to carry over the existing occurrences of unlikely() and not to introduce
gratuitous and unrelated changes. But because of the inconsistencies in
the use of unlikely() in the 9 occurrences that were collapsed into 3
wrappers, some change was unavoidable. I did not do any analysis of
the generated code with and without unlikely() to make a decision.

Michael