linux-kernel - Re: [PATCH] drivers/clocksource/qcom: Add missing iounmap() on error when reading clock frequency.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a3561cc-c6b3-4823-b488-fc8ebc53e1a6@linaro.org>
Date: Wed, 10 Jul 2024 13:54:01 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Ankit Agrawal <agrawal.ag.ankit@...il.com>,
 Bjorn Andersson <andersson@...nel.org>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>,
 Thomas Gleixner <tglx@...utronix.de>, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/clocksource/qcom: Add missing iounmap() on error
 when reading clock frequency.

On 10.07.2024 1:08 PM, Ankit Agrawal wrote:
> Add the missing iounmap() when clock frequency fails to get read by the
> of_property_read_u32() call.
> 
> Signed-off-by: Ankit Agrawal <agrawal.ag.ankit@...il.com>
> ---

Or even better, you can extract:

drivers/platform/x86/intel/pmc/core_ssram.c
32:DEFINE_FREE(pmc_core_iounmap, void __iomem *, iounmap(_T));

into a common header, call it something less intel-specific and use
it with __free() here

Konrad