[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Zo52mxIlrZmeeAzP@duo.ucw.cz>
Date: Wed, 10 Jul 2024 13:55:07 +0200
From: Pavel Machek <pavel@....cz>
To: Hans de Goede <hdegoede@...hat.com>
Cc: Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
stable@...r.kernel.org, Dmitry Torokhov <dmitry.torokhov@...il.com>,
linux-input@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.1 23/29] Input: silead - Always support 10
fingers
On Wed 2024-07-10 11:59:48, Hans de Goede wrote:
> Hi Pavel,
>
> On 7/10/24 11:58 AM, Pavel Machek wrote:
> > Hi!
> >
> >> From: Hans de Goede <hdegoede@...hat.com>
> >>
> >> [ Upstream commit 38a38f5a36da9820680d413972cb733349400532 ]
> >>
> >> When support for Silead touchscreens was orginal added some touchscreens
> >> with older firmware versions only supported 5 fingers and this was made
> >> the default requiring the setting of a "silead,max-fingers=10" uint32
> >> device-property for all touchscreen models which do support 10 fingers.
> >>
> >> There are very few models with the old 5 finger fw, so in practice the
> >> setting of the "silead,max-fingers=10" is boilerplate which needs to
> >> be copy and pasted to every touchscreen config.
> >>
> >> Reporting that 10 fingers are supported on devices which only support
> >> 5 fingers doesn't cause any problems for userspace in practice, since
> >> at max 4 finger gestures are supported anyways. Drop the max_fingers
> >> configuration and simply always assume 10 fingers.
> >
> > This does not fix a serious bug, should not be in stable.
>
> This patch is necessary for clean backporting of new DMI quirks added
> to drivers/platform/x86/touchscreen_dmi.c, so IMHO it does make sense
> as a stable series patch.
That's likely not reason it ended up it autosel, but why
not. "Stable-dep-of" tag would be nice in that case.
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)
Powered by blists - more mailing lists