linux-kernel - Re: [PATCH v2] gpio: mc33880: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Mc=0LgyH432JWCfdTwty1sYPX=ZViuoL6u3K_1SW5RnDw@mail.gmail.com>
Date: Wed, 10 Jul 2024 13:56:51 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Chen Ni <nichen@...as.ac.cn>
Cc: linus.walleij@...aro.org, grant.likely@...retlab.ca, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] gpio: mc33880: Convert comma to semicolon

On Wed, Jul 10, 2024 at 10:28 AM Chen Ni <nichen@...as.ac.cn> wrote:
>
> Replace a comma between expression statements by a semicolon.
>
> Fixes: c103de240439 ("gpio: reorganize drivers")

This is not correct. The commit that introduced that issue is
1e5db00687c1 ("gpio: add MC33880 driver"). I'll fix it when applying.

Bart

> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
> Changelog:
>
> v1 -> v2:
>
> 1. Add Fixes tag.
> ---
>  drivers/gpio/gpio-mc33880.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mc33880.c b/drivers/gpio/gpio-mc33880.c
> index 94f6fefc011b..5fb357d7b78a 100644
> --- a/drivers/gpio/gpio-mc33880.c
> +++ b/drivers/gpio/gpio-mc33880.c
> @@ -99,7 +99,7 @@ static int mc33880_probe(struct spi_device *spi)
>
>         mc->spi = spi;
>
> -       mc->chip.label = DRIVER_NAME,
> +       mc->chip.label = DRIVER_NAME;
>         mc->chip.set = mc33880_set;
>         mc->chip.base = pdata->base;
>         mc->chip.ngpio = PIN_NUMBER;
> --
> 2.25.1
>