linux-kernel - Re: [PATCH AUTOSEL 4.19] wifi: cfg80211: wext: add extra SIOCSIWSCAN data check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zo55KEC5MmfeXJxq@duo.ucw.cz>
Date: Wed, 10 Jul 2024 14:06:00 +0200
From: Pavel Machek <pavel@...x.de>
To: Greg KH <greg@...ah.com>
Cc: Pavel Machek <pavel@...x.de>, Sasha Levin <sashal@...nel.org>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Dmitry Antipov <dmantipov@...dex.ru>,
	syzbot+253cd2d2491df77c93ac@...kaller.appspotmail.com,
	Johannes Berg <johannes.berg@...el.com>, johannes@...solutions.net,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.19] wifi: cfg80211: wext: add extra SIOCSIWSCAN
 data check

On Wed 2024-07-10 12:24:55, Greg KH wrote:
> On Wed, Jul 10, 2024 at 12:04:15PM +0200, Pavel Machek wrote:
> > Hi!
> > 
> > > [ Upstream commit 6ef09cdc5ba0f93826c09d810c141a8d103a80fc ]
> > > 
> > > In 'cfg80211_wext_siwscan()', add extra check whether number of
> > > channels passed via 'ioctl(sock, SIOCSIWSCAN, ...)' doesn't exceed
> > > IW_MAX_FREQUENCIES and reject invalid request with -EINVAL otherwise.
> > 
> > This results in very confusing code in 4.19 at least. It should goto
> > out for consistency, exploting kfree(NULL) to be nop. Ok, not sure we
> > care...
> 
> kfree(NULL) is always supposed to be a nop, we have relied on that for
> decades, that's not an issue anywhere.

Take a look at the code, especially after this patch is applied.

BR,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)