linux-kernel - Re: [PATCH v5 10/14] staging: media: starfive: Add V4L2_CAP_IO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <y4rmftogfbsvs76juvrs6px7qlyqjxesg6wqupnrxiys7droea@rrwnc3nsrohr>
Date: Wed, 10 Jul 2024 14:18:11 +0200
From: Jacopo Mondi <jacopo.mondi@...asonboard.com>
To: Changhuang Liang <changhuang.liang@...rfivetech.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Hans Verkuil <hverkuil-cisco@...all.nl>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, 
	Jean-Michel Hautbois <jeanmichel.hautbois@...asonboard.com>, Benjamin Gaignard <benjamin.gaignard@...labora.com>, 
	Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>, Mingjia Zhang <mingjia.zhang@...iatek.com>, 
	Jack Zhu <jack.zhu@...rfivetech.com>, Keith Zhao <keith.zhao@...rfivetech.com>, 
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v5 10/14] staging: media: starfive: Add V4L2_CAP_IO_MC
 capability

Hi Changhuang

On Tue, Jul 09, 2024 at 01:38:20AM GMT, Changhuang Liang wrote:
> Add V4L2_CAP_IO_MC capabality for video device. User space can enumerate
> formats by mbus code.
>
> Signed-off-by: Changhuang Liang <changhuang.liang@...rfivetech.com>
> ---
>  drivers/staging/media/starfive/camss/stf-video.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/starfive/camss/stf-video.c b/drivers/staging/media/starfive/camss/stf-video.c
> index 2203605ec9c7..8c6c45d8b7a1 100644
> --- a/drivers/staging/media/starfive/camss/stf-video.c
> +++ b/drivers/staging/media/starfive/camss/stf-video.c
> @@ -668,7 +668,7 @@ int stf_video_register(struct stfcamss_video *video,
>  	}
>
>  	vdev->fops = &stf_vid_fops;
> -	vdev->device_caps |= V4L2_CAP_STREAMING;
> +	vdev->device_caps |= V4L2_CAP_STREAMING | V4L2_CAP_IO_MC;

Does this set the flag for the stat node as well ? Not that it hurts
but filtering on mbus code where only METADATA_FIXED is allowed
doesn't make much sense ?

Same for the parameters node

>  	vdev->entity.ops = &stf_media_ops;
>  	vdev->vfl_dir = VFL_DIR_RX;
>  	vdev->release = stf_video_release;
> --
> 2.25.1
>
>