linux-kernel - Re: [PATCH v2] fs: nfs: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab51cd2e8fef48dac690ca4549b409269ff9beae.camel@kernel.org>
Date: Wed, 10 Jul 2024 08:27:48 -0400
From: Jeff Layton <jlayton@...nel.org>
To: Jeff Johnson <quic_jjohnson@...cinc.com>, Trond Myklebust
 <trond.myklebust@...merspace.com>, Anna Schumaker <anna@...nel.org>, Chuck
 Lever <chuck.lever@...cle.com>, Neil Brown <neilb@...e.de>, Olga
 Kornievskaia <kolga@...app.com>,  Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey
 <tom@...pey.com>, Trond Myklebust <trondmy@...nel.org>
Cc: linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] fs: nfs: add missing MODULE_DESCRIPTION() macros

On Tue, 2024-07-09 at 13:47 -0700, Jeff Johnson wrote:
> On 6/25/2024 9:44 AM, Jeff Layton wrote:
> > On Tue, 2024-06-25 at 09:42 -0700, Jeff Johnson wrote:
> > > Fix the 'make W=1' warnings:
> > > WARNING: modpost: missing MODULE_DESCRIPTION() in
> > > fs/nfs_common/nfs_acl.o
> > > WARNING: modpost: missing MODULE_DESCRIPTION() in
> > > fs/nfs_common/grace.o
> > > WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfs.o
> > > WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv2.o
> > > WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv3.o
> > > WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv4.o
> > > 
> > > Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> > > ---
> > > Changes in v2:
> > > - Updated the description in grace.c per Jeff Layton
> > > - Link to v1:
> > > https://lore.kernel.org/r/20240527-md-fs-nfs-v1-1-64a15e9b53a6@quicinc.com
> > > ---
> > >  fs/nfs/inode.c         | 1 +
> > >  fs/nfs/nfs2super.c     | 1 +
> > >  fs/nfs/nfs3super.c     | 1 +
> > >  fs/nfs/nfs4super.c     | 1 +
> > >  fs/nfs_common/grace.c  | 1 +
> > >  fs/nfs_common/nfsacl.c | 1 +
> > >  6 files changed, 6 insertions(+)
> > > 

Given that this is mostly client-side changes, this should probably go
through the client tree. Anna, could you pick this one up?

Thanks,
Jeff

> > > diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
> > > index acef52ecb1bb..57c473e9d00f 100644
> > > --- a/fs/nfs/inode.c
> > > +++ b/fs/nfs/inode.c
> > > @@ -2538,6 +2538,7 @@ static void __exit exit_nfs_fs(void)
> > >  
> > >  /* Not quite true; I just maintain it */
> > >  MODULE_AUTHOR("Olaf Kirch <okir@...ad.swb.de>");
> > > +MODULE_DESCRIPTION("NFS client support");
> > >  MODULE_LICENSE("GPL");
> > >  module_param(enable_ino64, bool, 0644);
> > >  
> > > diff --git a/fs/nfs/nfs2super.c b/fs/nfs/nfs2super.c
> > > index 467f21ee6a35..b1badc70bd71 100644
> > > --- a/fs/nfs/nfs2super.c
> > > +++ b/fs/nfs/nfs2super.c
> > > @@ -26,6 +26,7 @@ static void __exit exit_nfs_v2(void)
> > >  	unregister_nfs_version(&nfs_v2);
> > >  }
> > >  
> > > +MODULE_DESCRIPTION("NFSv2 client support");
> > >  MODULE_LICENSE("GPL");
> > >  
> > >  module_init(init_nfs_v2);
> > > diff --git a/fs/nfs/nfs3super.c b/fs/nfs/nfs3super.c
> > > index 8a9be9e47f76..20a80478449e 100644
> > > --- a/fs/nfs/nfs3super.c
> > > +++ b/fs/nfs/nfs3super.c
> > > @@ -27,6 +27,7 @@ static void __exit exit_nfs_v3(void)
> > >  	unregister_nfs_version(&nfs_v3);
> > >  }
> > >  
> > > +MODULE_DESCRIPTION("NFSv3 client support");
> > >  MODULE_LICENSE("GPL");
> > >  
> > >  module_init(init_nfs_v3);
> > > diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c
> > > index 8da5a9c000f4..b29a26923ce0 100644
> > > --- a/fs/nfs/nfs4super.c
> > > +++ b/fs/nfs/nfs4super.c
> > > @@ -332,6 +332,7 @@ static void __exit exit_nfs_v4(void)
> > >  	nfs_dns_resolver_destroy();
> > >  }
> > >  
> > > +MODULE_DESCRIPTION("NFSv4 client support");
> > >  MODULE_LICENSE("GPL");
> > >  
> > >  module_init(init_nfs_v4);
> > > diff --git a/fs/nfs_common/grace.c b/fs/nfs_common/grace.c
> > > index 1479583fbb62..27cd0d13143b 100644
> > > --- a/fs/nfs_common/grace.c
> > > +++ b/fs/nfs_common/grace.c
> > > @@ -139,6 +139,7 @@ exit_grace(void)
> > >  }
> > >  
> > >  MODULE_AUTHOR("Jeff Layton <jlayton@...marydata.com>");
> > > +MODULE_DESCRIPTION("NFS client and server infrastructure");
> > >  MODULE_LICENSE("GPL");
> > >  module_init(init_grace)
> > >  module_exit(exit_grace)
> > > diff --git a/fs/nfs_common/nfsacl.c b/fs/nfs_common/nfsacl.c
> > > index 5a5bd85d08f8..ea382b75b26c 100644
> > > --- a/fs/nfs_common/nfsacl.c
> > > +++ b/fs/nfs_common/nfsacl.c
> > > @@ -29,6 +29,7 @@
> > >  #include <linux/nfs3.h>
> > >  #include <linux/sort.h>
> > >  
> > > +MODULE_DESCRIPTION("NFS ACL support");
> > >  MODULE_LICENSE("GPL");
> > >  
> > >  struct nfsacl_encode_desc {
> > > 
> > > ---
> > > base-commit: 50736169ecc8387247fe6a00932852ce7b057083
> > > change-id: 20240527-md-fs-nfs-42f19eb60b50
> > > 
> > 
> > Reviewed-by: Jeff Layton <jlayton@...nel.org>
> 
> I don't see this in linux-next yet so following up to see if anything else is
> needed to get this merged.
> 

-- 
Jeff Layton <jlayton@...nel.org>