linux-kernel - Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zo6I47BQlLnNN3R-@krava>
Date: Wed, 10 Jul 2024 15:13:07 +0200
From: Jiri Olsa <olsajiri@...il.com>
To: Menglong Dong <menglong8.dong@...il.com>
Cc: mhiramat@...nel.org, rostedt@...dmis.org,
	mathieu.desnoyers@...icios.com, linux-kernel@...r.kernel.org,
	linux-trace-kernel@...r.kernel.org, bpf@...r.kernel.org,
	Menglong Dong <dongml2@...natelecom.cn>
Subject: Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of
 bpf_kprobe_override

On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote:
> After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction

should be in Fixes: tag probably ?

> pointer with original one"), "bpf_kprobe_override" is not used anywhere
> anymore, and we can remove it now.
> 
> Signed-off-by: Menglong Dong <dongml2@...natelecom.cn>

lgtm, cc-ing Masami

Acked-by: Jiri Olsa <jolsa@...nel.org>

jirka

> ---
>  include/linux/trace_events.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
> index 9df3e2973626..9435185c10ef 100644
> --- a/include/linux/trace_events.h
> +++ b/include/linux/trace_events.h
> @@ -880,7 +880,6 @@ do {									\
>  struct perf_event;
>  
>  DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
> -DECLARE_PER_CPU(int, bpf_kprobe_override);
>  
>  extern int  perf_trace_init(struct perf_event *event);
>  extern void perf_trace_destroy(struct perf_event *event);
> -- 
> 2.39.2
> 
>