linux-kernel - Re: [PATCH 6/6] arm64: dts: imx93: add ddr edac support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zo6c+cFt3LL0kQEI@lizhi-Precision-Tower-5810>
Date: Wed, 10 Jul 2024 10:38:49 -0400
From: Frank Li <Frank.li@....com>
To: Peng Fan <peng.fan@....com>
Cc: York Sun <york.sun@....com>, Borislav Petkov <bp@...en8.de>,
	Tony Luck <tony.luck@...el.com>, James Morse <james.morse@....com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Robert Richter <rric@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Borislav Petkov <bp@...e.de>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 6/6] arm64: dts: imx93: add ddr edac support

On Wed, Jul 10, 2024 at 02:25:02AM +0000, Peng Fan wrote:
> > Subject: [PATCH 6/6] arm64: dts: imx93: add ddr edac support
> > 
> > Add ddr edac support for imx93.
> > 
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx93.dtsi | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > index 4a3f42355cb8f..6faba848fe286 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > @@ -1279,6 +1279,14 @@ usbmisc2: usbmisc@...00200 {
> >  			#index-cells = <1>;
> >  		};
> > 
> > +		memory-controller@...00000 {
> > +			compatible = "nxp,imx9-memory-controller";
> > +			reg = <0x4e300000 0x800>, <0x4e301000
> > 0x1000>;
> > +			reg-names = "ctrl", "inject";
> > +			interrupts = <GIC_SPI 91
> > IRQ_TYPE_LEVEL_HIGH>;
> > +			little-endian;
> > +		};
> > +
> >  		ddr-pmu@...00dc0 {
> 
> Should the ddr-pmu be part of memory controller?

imx9-memory-controller is actually EDAC, which independent with ddr pmu.
I think ddr-pmu should be seperate node.

Frank

> 
> Regards,
> Peng.
> 
> >  			compatible = "fsl,imx93-ddr-pmu";
> >  			reg = <0x4e300dc0 0x200>;
> > 
> > --
> > 2.34.1
> > 
>