linux-kernel - Re: [PATCH] vfio: Reuse file f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240710144044.GA1482543@nvidia.com>
Date: Wed, 10 Jul 2024 11:40:44 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Yan Zhao <yan.y.zhao@...el.com>
Cc: Yi Liu <yi.l.liu@...el.com>, "Tian, Kevin" <kevin.tian@...el.com>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alex.williamson@...hat.com" <alex.williamson@...hat.com>,
	"peterx@...hat.com" <peterx@...hat.com>,
	"ajones@...tanamicro.com" <ajones@...tanamicro.com>
Subject: Re: [PATCH] vfio: Reuse file f_inode as vfio device inode

On Mon, Jul 01, 2024 at 01:48:07PM +0800, Yan Zhao wrote:

> No, I don't have such a need.
> I just find it's confusing to say "Only the group path allows the device to be
> opened multiple times. The device cdev path doesn't have a secure way for it",
> since it's still doable to achieve the same "secure" level in cdev path and the
> group path is not that "secure" :)

It is more that the group path had an API that allowed for multiple
FDs without an actual need to ever use that. You can always make more
FDs with dup.

There is no reason for this functionality, we just have to keep it
working as a matter of uABI compatability and we are being more strict
in the new APIs.

Jason