linux-kernel - Re: [PATCH v2 2/3] mm: Remove pud_user() from asm-generic/pgtable-nopmd.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zo6enCwreppncIel@x1n>
Date: Wed, 10 Jul 2024 10:45:48 -0400
From: Peter Xu <peterx@...hat.com>
To: Christophe Leroy <christophe.leroy@...roup.eu>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, x86@...nel.org, linux-riscv@...ts.infradead.org,
	Oscar Salvador <osalvador@...e.de>
Subject: Re: [PATCH v2 2/3] mm: Remove pud_user() from
 asm-generic/pgtable-nopmd.h

On Wed, Jul 10, 2024 at 09:51:21AM +0200, Christophe Leroy wrote:
> Commit 2c8a81dc0cc5 ("riscv/mm: fix two page table check related
> issues") added pud_user() in include/asm-generic/pgtable-nopmd.h
> 
> But pud_user() only exists on ARM64 and RISCV and is not expected
> by any part of MM.
> 
> Add the missing definition in arch/riscv/include/asm/pgtable-32.h
> and remove it from asm-generic/pgtable-nopmd.h
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>

I assume you double checked the riscv cross-builds on both 32/64. It looks
correct:

Reviewed-by: Peter Xu <peterx@...hat.com>

-- 
Peter Xu