linux-kernel - Re: [PATCH v1 net-next] leds: trigger: netdev: Add support for tx_err and rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <702949fc-96af-4202-a404-c8678a99fab4@lunn.ch>
Date: Wed, 10 Jul 2024 16:46:25 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Lukasz Majewski <lukma@...x.de>
Cc: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Christian Marangi <ansuelsmth@...il.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Marek Behún <kabel@...nel.org>,
	Daniel Golle <daniel@...rotopia.org>,
	Li Zetao <lizetao1@...wei.com>, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 net-next] leds: trigger: netdev: Add support for
 tx_err and rx_err notification with LEDs

On Wed, Jul 10, 2024 at 12:06:51PM +0200, Lukasz Majewski wrote:
> This patch provides support for enabling blinking of LEDs when RX or TX
> errors are detected.
> 
> Approach taken in this patch is similar to one for TX or RX data
> transmission indication (i.e. TRIGGER_NETDEV_TX/RX attribute).
> 
> One can inspect transmission errors with:
> ip -s link show eth0
> 
> Example LED configuration:
> cd /sys/devices/platform/amba_pl@...001a000.leds/leds/
> echo netdev > mode:blue/trigger && \
> echo eth0 > mode:blue/device_name && \
> echo 1 > mode:blue/tx_err
> 
> Signed-off-by: Lukasz Majewski <lukma@...x.de>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew