linux-kernel - Re: [PATCH v2 3/3] mm: Add p{g/4}d_leaf() in asm-generic/pgtable-nop{4/u}d.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b37a0bb5-ba6f-4db3-af8f-83e06eec086d@cs-soprasteria.com>
Date: Wed, 10 Jul 2024 14:54:36 +0000
From: LEROY Christophe <christophe.leroy2@...soprasteria.com>
To: Peter Xu <peterx@...hat.com>, Christophe Leroy
	<christophe.leroy@...roup.eu>
CC: Andrew Morton <akpm@...ux-foundation.org>, Arnd Bergmann <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>, "x86@...nel.org" <x86@...nel.org>,
	"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>, Oscar
 Salvador <osalvador@...e.de>
Subject: Re: [PATCH v2 3/3] mm: Add p{g/4}d_leaf() in
 asm-generic/pgtable-nop{4/u}d.h



Le 10/07/2024 à 16:46, Peter Xu a écrit :
> On Wed, Jul 10, 2024 at 09:51:22AM +0200, Christophe Leroy wrote:
>> Commit 2c8a81dc0cc5 ("riscv/mm: fix two page table check related
>> issues") added pud_leaf() in include/asm-generic/pgtable-nopmd.h
>>
>> Do the same for p4d_leaf() and pgd_leaf() to avoid getting them
>> erroneously defined by architectures that do not implement the
>> related page level.
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
>> ---
>> v2: Added pXd_leaf macro as well in asm-generic/pgtable-nopXd.h to cohabit with the fallback
>> ---
> 
> Thanks.  I'd drop the inline functions, but no strong opinions.

Inline functions enable type checking.

With a macro you would be able to write pud_leaf(pgd) without the 
compiler noticing the mistake.

All other helpers in asm-generic/pgtable-nopXd.h are functions so from 
my point of view it makes sense to keep them as functions not macros.

> 
> Reviewed-by: Peter Xu <peterx@...hat.com>
> 

Thanks.