linux-kernel - Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7cd921b3-fed9-4b0c-9ba8-381e45ef4218@perex.cz>
Date: Thu, 11 Jul 2024 18:08:38 +0200
From: Jaroslav Kysela <perex@...ex.cz>
To: Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
 Shuah Khan <shuah@...nel.org>
Cc: linux-sound@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kselftest/alsa: Use card name rather than number in test
 names

On 11. 07. 24 16:33, Mark Brown wrote:
> Currently for the PCM and mixer tests we report test names which identify
> the card being tested with the card number. This ensures we have unique
> names but since card numbers are dynamically assigned at runtime the names
> we end up with will often not be stable on systems with multiple cards
> especially where those cards are provided by separate modules loeaded at
> runtime. This makes it difficult for automated systems and UIs to relate
> test results between runs on affected platforms.
> 
> Address this by replacing our use of card numbers with card names which are
> more likely to be stable across runs. We use the long name since in the
> case where we have two of the same card it is more likely to include
> deduplication information (eg, HDA cards include the address/IRQ). The
> resulting information is not the most beautiful for human readers but the
> majority of kselftest output consumption is automated systems and it wasn't
> that great anyway.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>

I think that a combination of card number and card ID may be sufficient (and a 
compromise). It's shorter and user-friendly. Additionally, a table may be 
printed at the beginning of report with card number, card ID and long card 
name for further processing and identification.

					Jaroslav

-- 
Jaroslav Kysela <perex@...ex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.