[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CABVgOS=4N3GMjBsTnW=jbzkZbqo4Wwh5wpLod0_r+A2q_vxnGw@mail.gmail.com>
Date: Thu, 11 Jul 2024 11:48:57 +0800
From: David Gow <davidgow@...gle.com>
To: Eric Chan <ericchancf@...gle.com>
Cc: brendan.higgins@...ux.dev, rmoar@...gle.com,
linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] kunit: Fix the comment of KUNIT_ASSERT_STRNEQ as assertion
On Thu, 11 Jul 2024 at 01:06, Eric Chan <ericchancf@...gle.com> wrote:
>
> The current comment for KUNIT_ASSERT_STRNEQ incorrectly describes it as
> an expectation. Since KUNIT_ASSERT_STRNEQ is an assertion, updates the
> comment to correctly refer to it as such.
>
> Signed-off-by: Eric Chan <ericchancf@...gle.com>
> ---
Nice catch -- copy-and-paste strikes again!
Reviewed-by: David Gow <davidgow@...gle.com>
Cheers,
-- David
> include/kunit/test.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/kunit/test.h b/include/kunit/test.h
> index 61637ef32302..87a232421089 100644
> --- a/include/kunit/test.h
> +++ b/include/kunit/test.h
> @@ -1420,12 +1420,12 @@ do { \
> ##__VA_ARGS__)
>
> /**
> - * KUNIT_ASSERT_STRNEQ() - Expects that strings @left and @right are not equal.
> + * KUNIT_ASSERT_STRNEQ() - An assertion that strings @left and @right are not equal.
> * @test: The test context object.
> * @left: an arbitrary expression that evaluates to a null terminated string.
> * @right: an arbitrary expression that evaluates to a null terminated string.
> *
> - * Sets an expectation that the values that @left and @right evaluate to are
> + * Sets an assertion that the values that @left and @right evaluate to are
> * not equal. This is semantically equivalent to
> * KUNIT_ASSERT_TRUE(@test, strcmp((@left), (@right))). See KUNIT_ASSERT_TRUE()
> * for more information.
> --
> 2.45.2.803.g4e1b14247a-goog
>
Download attachment "smime.p7s" of type "application/pkcs7-signature" (4014 bytes)
Powered by blists - more mailing lists