linux-kernel - Re: [PATCH] spmi: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3fbab686-5a66-4b4e-b640-55426b2e1f57@quicinc.com>
Date: Thu, 11 Jul 2024 11:09:23 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Stephen Boyd
	<sboyd@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] spmi: add missing MODULE_DESCRIPTION() macros

On 6/26/24 09:15, Jeff Johnson wrote:
> On 6/9/2024 5:40 PM, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/spmi/hisi-spmi-controller.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/spmi/spmi-pmic-arb.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
>> ---
>>   drivers/spmi/hisi-spmi-controller.c | 1 +
>>   drivers/spmi/spmi-pmic-arb.c        | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c
>> index fa068b34b040..3cafdf22c909 100644
>> --- a/drivers/spmi/hisi-spmi-controller.c
>> +++ b/drivers/spmi/hisi-spmi-controller.c
>> @@ -344,6 +344,7 @@ static void __exit spmi_controller_exit(void)
>>   }
>>   module_exit(spmi_controller_exit);
>>   
>> +MODULE_DESCRIPTION("Hisilicon 3670 SPMI Controller driver");
>>   MODULE_LICENSE("GPL v2");
>>   MODULE_VERSION("1.0");
>>   MODULE_ALIAS("platform:spmi_controller");
>> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
>> index 791cdc160c51..f240fcc5a4e1 100644
>> --- a/drivers/spmi/spmi-pmic-arb.c
>> +++ b/drivers/spmi/spmi-pmic-arb.c
>> @@ -1891,5 +1891,6 @@ static struct platform_driver spmi_pmic_arb_driver = {
>>   };
>>   module_platform_driver(spmi_pmic_arb_driver);
>>   
>> +MODULE_DESCRIPTION("Qualcomm MSM SPMI Controller (PMIC Arbiter) driver");
>>   MODULE_LICENSE("GPL v2");
>>   MODULE_ALIAS("platform:spmi_pmic_arb");
>>
>> ---
>> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
>> change-id: 20240609-md-drivers-spmi-51a13baa2301
> 
> Following up to see if anything else is needed from me. Hoping to see this in
> linux-next so I can remove it from my tracking spreadsheet :)

I still don't see this in linux-next.
Adding Greg KH since seems he's been merging this driver.
My hope is to have these warnings fixed tree-wide in 6.11.

/jeff