linux-kernel - Re: [PATCH net-next v16 12/13] selftests: add ncdevmem, netcat for devmem TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0be43301-9df7-4b7f-9932-b820841712e3@nvidia.com>
Date: Thu, 11 Jul 2024 11:34:32 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Mina Almasry <almasrymina@...gle.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-alpha@...r.kernel.org,
 linux-mips@...r.kernel.org, linux-parisc@...r.kernel.org,
 sparclinux@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 linux-arch@...r.kernel.org, linux-kselftest@...r.kernel.org,
 bpf@...r.kernel.org, linux-media@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, Donald Hunter <donald.hunter@...il.com>,
 Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Jonathan Corbet <corbet@....net>,
 Richard Henderson <richard.henderson@...aro.org>,
 Ivan Kokshaysky <ink@...assic.park.msu.ru>, Matt Turner
 <mattst88@...il.com>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
 Helge Deller <deller@....de>, Andreas Larsson <andreas@...sler.com>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 Ilias Apalodimas <ilias.apalodimas@...aro.org>,
 Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Arnd Bergmann <arnd@...db.de>,
 Steffen Klassert <steffen.klassert@...unet.com>,
 Herbert Xu <herbert@...dor.apana.org.au>, David Ahern <dsahern@...nel.org>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 Shuah Khan <shuah@...nel.org>, Sumit Semwal <sumit.semwal@...aro.org>,
 Christian König <christian.koenig@....com>,
 Bagas Sanjaya <bagasdotme@...il.com>, Christoph Hellwig <hch@...radead.org>,
 Nikolay Aleksandrov <razor@...ckwall.org>, Taehee Yoo <ap420073@...il.com>,
 Pavel Begunkov <asml.silence@...il.com>, David Wei <dw@...idwei.uk>,
 Jason Gunthorpe <jgg@...pe.ca>, Yunsheng Lin <linyunsheng@...wei.com>,
 Shailend Chand <shailend@...gle.com>,
 Harshitha Ramamurthy <hramamurthy@...gle.com>,
 Shakeel Butt <shakeel.butt@...ux.dev>, Jeroen de Borst
 <jeroendb@...gle.com>, Praveen Kaligineedi <pkaligineedi@...gle.com>,
 Stanislav Fomichev <sdf@...gle.com>
Subject: Re: [PATCH net-next v16 12/13] selftests: add ncdevmem, netcat for
 devmem TCP

On 7/11/24 8:28 AM, Mina Almasry wrote:
> On Wed, Jul 10, 2024 at 5:44 PM John Hubbard <jhubbard@...dia.com> wrote:
>>
>> On 7/9/24 5:17 PM, Mina Almasry wrote:
>> ...
>>> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
>>> index bc3925200637c..39420a6e86b7f 100644
>>> --- a/tools/testing/selftests/net/Makefile
>>> +++ b/tools/testing/selftests/net/Makefile
>>> @@ -95,6 +95,11 @@ TEST_PROGS += fq_band_pktlimit.sh
>>>    TEST_PROGS += vlan_hw_filter.sh
>>>    TEST_PROGS += bpf_offload.py
>>>
>>> +# YNL files, must be before "include ..lib.mk"
>>> +EXTRA_CLEAN += $(OUTPUT)/libynl.a
>>> +YNL_GEN_FILES := ncdevmem
>>> +TEST_GEN_FILES += $(YNL_GEN_FILES)
>>> +
>>>    TEST_FILES := settings
>>>    TEST_FILES += in_netns.sh lib.sh net_helper.sh setup_loopback.sh setup_veth.sh
>>>
>>> @@ -104,6 +109,10 @@ TEST_INCLUDES := forwarding/lib.sh
>>>
>>>    include ../lib.mk
>>>
>>> +# YNL build
>>> +YNL_GENS := netdev
>>> +include ynl.mk
>>
>> This seems to be missing a rule to generate ynl.mk, right?
>>
> 
> Hi John,
> 
> tools/testing/selftests/net/ynl.mk was merged as part of this patch a
> few days ago:
> 
> https://patchwork.kernel.org/project/netdevbpf/patch/20240628003253.1694510-14-almasrymina@google.com/
> 
> Is it not working for you by any chance?
> 

Aha, I'm just not using the right tree, then. Thanks for clearing that up.

I was attempting this against mainline Linux, just for a quick look at the
selftests part, and that Doesn't Work. :)

thanks,
-- 
John Hubbard
NVIDIA