linux-kernel - Re: [PATCH sched_ext/for-6.11] sched_ext: Reverting @p->sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZpArK0qxZZI-0ykt@slm.duckdns.org>
Date: Thu, 11 Jul 2024 08:57:47 -1000
From: Tejun Heo <tj@...nel.org>
To: "Zhangqiao (2012 lab)" <zhangqiao22@...wei.com>
Cc: void@...ifault.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH sched_ext/for-6.11] sched_ext: Reverting @p->sched_class
 if @p->disallow is set

Hello,

On Thu, Jul 11, 2024 at 07:07:20PM +0800, Zhangqiao (2012 lab) wrote:
...
>  		if (p->policy == SCHED_EXT) {
>  			p->policy = SCHED_NORMAL;
> +			p->sched_class = &fair_sched_class;
>  			atomic_long_inc(&scx_nr_rejected);

Did you see any issues with the existing implementation? The policy is set
before the task is attached, so it should work fine. Also, you can't change
sched_class by just assigning to it.

Thanks.

-- 
tejun