linux-kernel - Re: [PATCH v4 1/3] dt-bindings: iio: adc: add AD4695 and similar ADCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172072996727.2951364.2243340017408650155.robh@kernel.org>
Date: Thu, 11 Jul 2024 14:32:47 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: linux-kernel@...r.kernel.org, 
 Nuno Sá <nuno.sa@...log.com>, linux-doc@...r.kernel.org, 
 Jonathan Cameron <jic23@...nel.org>, Jonathan Corbet <corbet@....net>, 
 devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, 
 linux-iio@...r.kernel.org, Conor Dooley <conor.dooley@...rochip.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Michael Hennerich <michael.hennerich@...log.com>
Subject: Re: [PATCH v4 1/3] dt-bindings: iio: adc: add AD4695 and similar
 ADCs


On Thu, 11 Jul 2024 14:15:41 -0500, David Lechner wrote:
> Add device tree bindings for AD4695 and similar ADCs.
> 
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> Signed-off-by: David Lechner <dlechner@...libre.com>
> ---
> 
> Note, this may trigger a DT build warning "common-mode-channel: missing
> type definition" if the builder doesn't include the recently added
> common-mode-channel property [1]. This should be safe to ignore (passes
> make dt_binding_check locally).
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=testing&id=d86deaec1c5b0fb60c3619e8d2ae7a1d722fd2ad
> 
> v4 changes:
> * Picked up Conor's reviewed-by tag.
> 
> v3 changes:
> * Change interrupts to be per pin instead of per signal.
> * Drop diff-channels and single-channel properties.
> * Odd numbered pins added to common-mode-channel property enum.
> * REFGND and COM values changes to avoid confusion with pin numbers.
> * Add inX-supply properties for odd numbed input pins.
> 
> v2 changes:
> * Drop *-wlcsp compatible strings
> * Don't use fallback compatible strings
> * Reword supply descriptions
> * Use standard channel properties instead of adi,pin-pairing
> * Fix unnecessary | character
> * Fix missing blank line
> * Add header file with common mode channel macros
> ---
>  .../devicetree/bindings/iio/adc/adi,ad4695.yaml    | 256 +++++++++++++++++++++
>  MAINTAINERS                                        |  10 +
>  include/dt-bindings/iio/adi,ad4695.h               |   9 +
>  3 files changed, 275 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml: common-mode-channel: missing type definition

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240711-iio-adc-ad4695-v4-1-c31621113b57@baylibre.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.