linux-kernel - Re: [PATCH] mm/huge_memory: Avoid PMD-size page cache if needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZpBEwEn3swH7IFbI@casper.infradead.org>
Date: Thu, 11 Jul 2024 21:46:56 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Gavin Shan <gshan@...hat.com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, william.kucharski@...cle.com,
	david@...hat.com, ryan.roberts@....com, shan.gavin@...il.com
Subject: Re: [PATCH] mm/huge_memory: Avoid PMD-size page cache if needed

On Thu, Jul 11, 2024 at 08:48:40PM +1000, Gavin Shan wrote:
> +++ b/mm/huge_memory.c
> @@ -136,7 +136,8 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma,
>  
>  		while (orders) {
>  			addr = vma->vm_end - (PAGE_SIZE << order);
> -			if (thp_vma_suitable_order(vma, addr, order))
> +			if (!(vma->vm_file && order > MAX_PAGECACHE_ORDER) &&
> +			    thp_vma_suitable_order(vma, addr, order))
>  				break;

Why does 'orders' even contain potential orders that are larger than
MAX_PAGECACHE_ORDER?

We do this at the top:

        orders &= vma_is_anonymous(vma) ?
                        THP_ORDERS_ALL_ANON : THP_ORDERS_ALL_FILE;

include/linux/huge_mm.h:#define THP_ORDERS_ALL_FILE     (BIT(PMD_ORDER) | BIT(PUD_ORDER))

... and that seems very wrong.  We support all kinds of orders for
files, not just PMD order.  We don't support PUD order at all.

What the hell is going on here?